Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for static tags from env and instance config #34387

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add checks for static tags from env and instance config #34387

wants to merge 6 commits into from
+15 −5

Conversation

justin-lesko
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/container-platform The Container Platform Team short review PR is simple enough to be reviewed quickly labels Feb 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57131547 --os-family=ubuntu

Note: This applies to commit ea6c5c7

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor 526645bb889d540d8ce7a39fb6cc932b8ea58ca6

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.04MB ⚠️ 849.87MB 849.83MB 0.50MB
datadog-agent-x86_64-suse 0.04MB ⚠️ 849.87MB 849.83MB 0.50MB
datadog-agent-aarch64-rpm 0.03MB ⚠️ 839.95MB 839.92MB 0.50MB
datadog-agent-amd64-deb 0.02MB ⚠️ 840.08MB 840.07MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 830.18MB 830.17MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 37.96MB 37.96MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 443.28MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.02MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.09MB 62.09MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.26MB 59.26MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.33MB 59.33MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025 •
edited
Loading

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 812.88MiB 847.49MiB 196.91MiB 212.33MiB
✅ static_quality_gate_agent_deb_arm64 803.5MiB 836.66MiB 178.04MiB 192.5MiB
✅ static_quality_gate_agent_rpm_amd64 812.92MiB 847.82MiB 199.33MiB 215.76MiB
✅ static_quality_gate_agent_rpm_arm64 803.45MiB 836.66MiB 180.86MiB 194.24MiB
✅ static_quality_gate_agent_suse_amd64 812.99MiB 847.82MiB 199.33MiB 215.76MiB
✅ static_quality_gate_agent_suse_arm64 803.36MiB 836.66MiB 180.86MiB 194.24MiB
✅ static_quality_gate_dogstatsd_deb_amd64 37.67MiB 49.7MiB 9.78MiB 20.6MiB
✅ static_quality_gate_dogstatsd_deb_arm64 36.27MiB 48.1MiB 8.49MiB 19.1MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
✅ static_quality_gate_dogstatsd_suse_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
✅ static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.88MiB 24.8MiB
✅ static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
✅ static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
✅ static_quality_gate_iot_agent_rpm_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
✅ static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
✅ static_quality_gate_docker_agent_amd64 897.31MiB 931.7MiB 300.94MiB 318.67MiB
✅ static_quality_gate_docker_agent_arm64 911.13MiB 944.08MiB 286.43MiB 303.0MiB
✅ static_quality_gate_docker_agent_jmx_amd64 1.07GiB 1.1GiB 376.02MiB 393.75MiB
✅ static_quality_gate_docker_agent_jmx_arm64 1.07GiB 1.1GiB 357.52MiB 373.71MiB
✅ static_quality_gate_docker_dogstatsd_amd64 45.81MiB 57.88MiB 17.28MiB 28.29MiB
✅ static_quality_gate_docker_dogstatsd_arm64 44.45MiB 56.27MiB 16.16MiB 27.06MiB
✅ static_quality_gate_docker_cluster_agent_amd64 264.94MiB 274.78MiB 106.35MiB 116.28MiB
✅ static_quality_gate_docker_cluster_agent_arm64 280.92MiB 290.82MiB 101.18MiB 111.12MiB

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Feb 24, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a18e0846-15dd-4f02-b57a-7122f40be319

Baseline: 526645b
Comparison: ea6c5c7
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ file_to_blackhole_500ms_latency egress throughput +0.07 [-0.71, +0.86] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.71, +0.85] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.03 [-0.81, +0.86] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.02 [-0.61, +0.65] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.81, +0.83] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.00 [-0.67, +0.67] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.00 [-0.84, +0.83] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.28, +0.27] 1 Logs
➖ file_tree memory utilization -0.05 [-0.10, -0.00] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.10 [-0.15, -0.05] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.12 [-0.59, +0.36] 1 Logs
➖ quality_gate_idle memory utilization -0.18 [-0.23, -0.13] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput -0.21 [-0.27, -0.14] 1 Logs
➖ quality_gate_logs % cpu utilization -1.29 [-4.18, +1.59] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -2.19 [-3.09, -1.30] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10
✅ quality_gate_logs lost_bytes 10/10
✅ quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@justin-lesko
Copy link
Contributor Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

@dd-devflow
Copy link

dd-devflow bot commented Feb 25, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-25 23:03:06 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

2025-02-25 23:03:40 UTC ℹ️ Gitlab pipeline started

Started pipeline #56967197

@justin-lesko
Copy link
Contributor Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Feb 26, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-26 15:09:34 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

2025-02-26 15:10:18 UTC ℹ️ Gitlab pipeline started

Started pipeline #57062779

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ❌

Please find below the results from static quality gates

Error

Result Quality gate On disk size On disk size limit On wire size On wire size limit
❌ static_quality_gate_agent_suse_amd64 DataNotFound 847.82MiB DataNotFound 215.76MiB
Gate failure full details
Quality gate Error type Error message
static_quality_gate_agent_suse_amd64 StackTrace Traceback (most recent call last):
File "/go/src/github.com/DataDog/datadog-agent/tasks/quality_gates.py", line 121, in parse_and_trigger_gates
gate_mod.entrypoint(**gate_inputs)
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/static_quality_gate_agent_suse_amd64.py", line 5, in entrypoint
generic_package_agent_quality_gate(
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 69, in generic_package_agent_quality_gate
package_on_wire_size, package_on_disk_size = calculate_package_size(
^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 10, in calculate_package_size
extract_package(ctx=ctx, package_os=package_os, package_path=package_path, extract_dir=extract_dir)
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 72, in extract_package
return extract_rpm_package(ctx, package_path, extract_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 65, in extract_rpm_package
ctx.run(f"rpm2cpio {package_path}
Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 812.95MiB 847.49MiB 196.87MiB 212.33MiB
✅ static_quality_gate_agent_deb_arm64 803.49MiB 836.66MiB 178.29MiB 192.5MiB
✅ static_quality_gate_agent_rpm_amd64 812.84MiB 847.82MiB 199.32MiB 215.76MiB
✅ static_quality_gate_agent_rpm_arm64 803.47MiB 836.66MiB 180.84MiB 194.24MiB
✅ static_quality_gate_agent_suse_arm64 803.46MiB 836.66MiB 180.84MiB 194.24MiB
✅ static_quality_gate_dogstatsd_deb_amd64 37.67MiB 49.7MiB 9.78MiB 20.6MiB
✅ static_quality_gate_dogstatsd_deb_arm64 36.27MiB 48.1MiB 8.49MiB 19.1MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
✅ static_quality_gate_dogstatsd_suse_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
✅ static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.88MiB 24.8MiB
✅ static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.84MiB 22.8MiB
✅ static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
✅ static_quality_gate_iot_agent_rpm_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
✅ static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
✅ static_quality_gate_docker_agent_amd64 897.31MiB 931.7MiB 300.93MiB 318.67MiB
✅ static_quality_gate_docker_agent_arm64 911.13MiB 944.08MiB 286.43MiB 303.0MiB
✅ static_quality_gate_docker_agent_jmx_amd64 1.07GiB 1.1GiB 376.02MiB 393.75MiB
✅ static_quality_gate_docker_agent_jmx_arm64 1.07GiB 1.1GiB 357.52MiB 373.71MiB
✅ static_quality_gate_docker_dogstatsd_amd64 45.81MiB 57.88MiB 17.28MiB 28.29MiB
✅ static_quality_gate_docker_dogstatsd_arm64 44.45MiB 56.27MiB 16.16MiB 27.06MiB
✅ static_quality_gate_docker_cluster_agent_amd64 264.94MiB 274.78MiB 106.35MiB 116.28MiB
✅ static_quality_gate_docker_cluster_agent_arm64 280.92MiB 290.82MiB 101.18MiB 111.12MiB

@justin-lesko
Copy link
Contributor Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

@dd-devflow
Copy link

dd-devflow bot commented Feb 26, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-26 20:20:17 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto
If you need support, contact us on Slack #devflow!

2025-02-26 20:23:20 UTC 🚨 Devflow

Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": context deadline exceeded

Details 
child workflow execution error (type: devflow.Devflow_TriggerCiFromPr, workflowID: a0a8585d-2df1-44b7-9f7a-63bd3a1cee3c_26, runID: c676aa07-4888-4b1c-9201-bf8afef28e40, initiatedEventID: 26, startedEventID: 27): child workflow execution error (type: devflow.Devflow_TriggerCi, workflowID: c676aa07-4888-4b1c-9201-bf8afef28e40_14, runID: 76f3fc2e-eef1-4d2a-9bbe-469875c51630, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 26, startedEventID: 27, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose): Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": context deadline exceeded (type: Error, retryable: true): context deadline exceeded (type: deadlineExceededError, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 26, 2025 •
edited
Loading

[Fast Unit Tests Report]

On pipeline 57131547 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@justin-lesko
Copy link
Contributor Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

@dd-devflow
Copy link

dd-devflow bot commented Feb 26, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-26 21:11:50 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

2025-02-26 21:12:28 UTC ℹ️ Gitlab pipeline started

Started pipeline #57131547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justin-lesko